Codecov Report

Attention: Patch coverage is 84.02226% with 201 lines in your changes missing coverage. Please review.

Project coverage is 71.01%. Comparing base (78bcc0a) to head (5b5de16).
Report is 5 commits behind head on unstable.

@@             Coverage Diff              @@
##           unstable    #1658      +/-   ##
============================================
- Coverage     71.02%   71.01%   -0.02%     
============================================
  Files           121      121              
  Lines         65176    65218      +42     
============================================
+ Hits          46290    46313      +23     
- Misses        18886    18905      +19     

Awesome! Tbh, I'd prefer the complete change in one PR so we can get the benefit in memory usage. A separate commit within the same PR for the assignments and then a final commit to actually save memory in the object struct.

Feel free to write down you regexes so we can review those instead of alongside the actual diff. :D

Ok, I added objectSetVal.

I could post the python scripts I used, but they're pretty bad. I only worked on them to the extent that it'd save me time - They mangle a few instances but did the bulk of the editing for me. Here's the one I used for the last objectSetVal commit. The json I load is derived from VS Code's "find all references" feature.

import json

with open('ptrrefs.json') as f:
    refs = json.load(f)

for file in list(refs.keys()):
    with open(file, 'r') as src:
        lines = src.readlines()
    print('====', file, '====')
    for (lineno, char) in refs[file]:
        lineno -= 1 # line number is 1-based
        char -= 1 # char number also 1-based

        line = lines[lineno]
        count = line.count('->ptr = ')
        if count == 0:
            continue
        assert(count == 1)
        (robj, val_ptr) = line.strip()[:-1].split('->ptr = ')
        whitespace = line[:len(line) - len(line.lstrip())]
        print(lineno, line[:-1])
        lines[lineno] =  f'{whitespace}objectSetVal({robj}, {val_ptr});\n'

    with open(file, 'w') as src:
        src.writelines(lines)